git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-name-rev: don't use printf without format

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 3, 2008, 20:44 UTC
Message-ID
<7vvdyhu8v9.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<4895B641.1050500@lsrfire.ath.cx>
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
> printf() without an explicit format string is not a good coding practise,
> unless the printed string is guaranteed to not contain percent signs.  While
> fixing this, we might as well combine the calls to fwrite() and printf().

Good catch; I should have caught it when I applied the "split overlong function" patch, but I apparently was blind.

Thanks.
Previous: René Scharfe
Message 8 of 8 in “git-name-rev: allow --name-only in combination with --stdin”
  1. git-name-rev: allow --name-only in combination with --stdinPieter de Bie, Jul 31, 2008
  2. Junio C HamanoAug 1, 2008
  3. Johannes SchindelinAug 1, 2008
  4. builtin-name-rev: refactor stdin handling to its own functionPieter de Bie, Aug 1, 2008
  5. Junio C HamanoAug 1, 2008
  6. Junio C HamanoAug 2, 2008
  7. git-name-rev: don't use printf without formatRené Scharfe, Aug 3, 2008
  8. Junio C HamanoAug 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.