Re: [PATCH] git-name-rev: allow --name-only in combination with --stdin
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 1, 2008, 07:23 UTC
- Message-ID
- <7vtze5td00.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1217510434-94979-1-git-send-email-pdebie@ai.rug.nl>
Pieter de Bie <pdebie@ai.rug.nl> writes:
> Signed-off-by: Pieter de Bie <pdebie@ai.rug.nl> > --- > > Or was there a specific reason not to allow this?
I'll let Dscho answer that one.
Show 21 quoted lines
> diff --git a/builtin-name-rev.c b/builtin-name-rev.c
> index 85612c4..0536af4 100644
> --- a/builtin-name-rev.c
> +++ b/builtin-name-rev.c
> @@ -266,8 +266,14 @@ int cmd_name_rev(int argc, const char **argv, const char *prefix)
> if (!name)
> continue;
>
> - fwrite(p_start, p - p_start + 1, 1, stdout);
> - printf(" (%s)", name);
> + if (data.name_only) {
> + fwrite(p_start, p - p_start + 1 - 40, 1, stdout);
> + printf(name);
> + }
> + else {
> + fwrite(p_start, p - p_start + 1, 1, stdout);
> + printf(" (%s)", name);
> + }
> p_start = p + 1;
> }
> }Is it just me to find that this part is getting indented too deeply to be readable?