From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 03 Aug 2008 20:44:10 GMT
Subject: Re: [PATCH] git-name-rev: don't use printf without format
Message-ID: <7vvdyhu8v9.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <4895B641.1050500@lsrfire.ath.cx>

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> printf() without an explicit format string is not a good coding practise,
> unless the printed string is guaranteed to not contain percent signs.  While
> fixing this, we might as well combine the calls to fwrite() and printf().

Good catch; I should have caught it when I applied the "split overlong
function" patch, but I apparently was blind.

Thanks.