Re: [PATCH] builtin-name-rev: refactor stdin handling to its own function

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 1, 2008, 19:07 UTC
Message-ID: <7vtze4sgea.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1217589372-4151-1-git-send-email-pdebie@ai.rug.nl>

Pieter de Bie <pdebie@ai.rug.nl> writes:

Show 8 quoted lines

> Signed-off-by: Pieter de Bie <pdebie@ai.rug.nl>
> ---
>
>     On 1 aug 2008, at 09:23, Junio C Hamano wrote:
>     >Is it just me to find that this part is getting indented too deeply to be
>     >readable?
>
>     How about something like this then?

Much nicer, except that this refactoring should come first and then a new feature. Dropping those extra five 's' so that it would compile would be a nice bonus as well ;-)

Show 7 quoted lines

> ...
> +
> +			if (name_only) {
> +				fwrite(p_start, p - p_start + 1 - 40,
> +					1, stdout);sssss
> +				printf(name);
> +			}