Re: cvsimport still not working with cvsnt

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 27, 2011, 08:26 UTC
Message-ID: <7vvd056fyk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4D69DF29.8030701@burntmail.com>

Guy Rouillier <guyr@burntmail.com> writes:

Show 9 quoted lines

> As I suspected after reading how the cvspass file is read and written,
> CVSNT doesn't work with repositories with an equal sign in the
> repository name.  You can init it fine, and you can set up a password
> for it.  But if you try to login things go very wrong:
> ...
> Since CVSNT can't handle a repository with an equal sign in its name,
> I say we don't worry about this.  I say the same about the original
> CVS with a repository name with embedded spaces.  We certainly don't
> want to try to solve problems the original product doesn't solve.

Thanks; your observation matches my earlier suspicion.  So in short:

 - CVSNT does not work with repository path with an '=' in it, but does work
   with ones with a SP in it; and

 - CVS has trouble with repository path with a SP in it, but works with
   ones with an '=' in it just fine.

Have I summarized it correctly?

So I agree that cvsimport should not worry about supporting repository path with an '=' in it, but we do need to make sure we work with one with a SP in it, when we are reading from cvspass file for CVSNT.

Similarly when we are reading from cvspass file for CVS, we should make sure we don't break with repository path with an '=' in it.

Do we already have such a solution in the thread? Can somebody conclude the discussion with a final, tested and applyable patch, please?