Re: cvsimport still not working with cvsnt
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 18, 2011, 18:34 UTC
- Message-ID
- <7voc69p4xu.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <4D5E1116.7040501@burntmail.com>
Guy Rouillier <guyr@burntmail.com> writes:
> ... I'm new to all this and I thought > perhaps one of the listed committers had to submit the official patch.
There is no _listed committers_ ;-) I was hoping either you as the original author of the patch or Martin as the area expert would respond, but as long as the result looks correct and explained well, it doesn't matter either way.
Just one hopefully final question.
After stripping "/<version number><space>" from the beginning of the line in order to treat newer .cvspass file format and the original file format the same way, the code splits the remainder into two fields (cvsroot and lightly-scrambled password). It used to split only at a whitespace, which seems to be in line with the source of CVS 1.12.13 I looked at (it is in password_entry_parseline() function, src/login.c). You new code however also allows '=' to be a delimiter to be used for this split.
Is this change intentional? If so please explain why it is necessary in the commit log message.