Re: cvsimport still not working with cvsnt
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 23, 2011, 05:24 UTC
- Message-ID
- <7vpqqj9vc7.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <4D6471E8.4060001@burntmail.com>
Guy Rouillier <guyr@burntmail.com> writes:
> ... Note that this issue is not unique to CVSNT. What does > CVS do with CVSROOT containing a space character?
IIRC, the comparison is done against canonicalized cvsroot string, so that you can try to connect to :pserver:Xz.Com:/path/to/repo even after you ran "cvs -d :pserver:xz.com:/path/to/repo login" and I wouldn't be surprised if the canonicalization involved quoting SP. Since August 2009 nobody has complained with the current code that doesn't do any canonicalization, and I take that as a sign that nobody sane so far used a cvsroot with a space in it ;-). But that doesn't mean nobody sane has been using a cvsroot with an equal sign in it, so we would need to at least avoid splitting at an equal sign when reading from .cvsroot.
It probably is a good idea to port the cvsroot canonicalization code to cvsimport in any case.