Re: cvsimport still not working with cvsnt
- From
- Guy Rouillier <guyr@burntmail.com>
- Date
- Jan 14, 2011, 06:38 UTC
- Message-ID
- <4D2FEF49.8070205@burntmail.com>
- In-Reply-To
- <AANLkTikreDJmUPfwNJ2ABivrafjvQNN6WrytNMAcse4A@mail.gmail.com>
On 1/10/2011 10:38 AM, Martin Langhoff wrote:
Show 14 quoted lines
> On Mon, Jan 10, 2011 at 2:33 AM, Guy Rouillier<guyr@burntmail.com> wrote:
>> Here is my patch for accomplishing the above. As this is my first time
>> submitting a patch, please let me know the correct procedure if
>> submitting a diff here is not appropriate. Thanks.
>
> The concept of what the patch is doing is good, but I'd recommend
>
> @cvspasslocations = ($ENV{'HOME'}."/cvspass", $ENV{'HOME'}."/.cvs/cvspass")
>
> foreach $cvspass (@cvspasslocations) {
> open(...
>
> and forgo the "matching" test.
>Martin, thanks for the reply. Have you had a chance to read the entire thread? The matching test was suggested by Emil.
This is my first patch submission. What is the process for reaching consensus?
-- Guy Rouillier