[RFH] Solaris portability
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 17, 2007, 00:33 UTC
- Message-ID
- <7vtznlww0t.fsf_-_@gitster.siamese.dyndns.org>
- In-Reply-To
- <Pine.LNX.4.64.0711161954510.7139@bianca.dialin.t-online.de>
Guido Ostkamp <git@ostkamp.fastmail.fm> writes:
Show 7 quoted lines
> On Thu, 15 Nov 2007, Junio C Hamano wrote: >> Are there problems with the implementation in compat/ directory, we >> ship specifically to help platforms without mkdtemp()? > > I checked again and the answer is 'yes'. The reason is trivial - for > Solaris 10 the workaround is not activated and my version of Solaris > 10 (Sparc) has no mkdtemp() in libc.so.
Thanks.
This makes me wonder if treating it just like strcasestr() might be simpler. Could folks with access to Solaris boxes of different vintages please see if the attached patch makes sense?
Can we also unify UNSETENV, SETENV, C99_FORMAT and STRTOUMAX, by the way?
diff --git a/Makefile b/Makefile index e830bc7..cabde81 100644 --- a/Makefile +++ b/Makefile @@ -412,26 +412,25 @@ endif ifeq ($(uname_S),SunOS) NEEDS_SOCKET = YesPlease NEEDS_NSL = YesPlease SHELL_PATH = /bin/bash NO_STRCASESTR = YesPlease NO_MEMMEM = YesPlease NO_HSTRERROR = YesPlease + NO_MKDTEMP = YesPlease ifeq ($(uname_R),5.8) NEEDS_LIBICONV = YesPlease NO_UNSETENV = YesPlease NO_SETENV = YesPlease - NO_MKDTEMP = YesPlease NO_C99_FORMAT = YesPlease NO_STRTOUMAX = YesPlease endif ifeq ($(uname_R),5.9) NO_UNSETENV = YesPlease NO_SETENV = YesPlease - NO_MKDTEMP = YesPlease NO_C99_FORMAT = YesPlease NO_STRTOUMAX = YesPlease endif INSTALL = ginstall TAR = gtar BASIC_CFLAGS += -D__EXTENSIONS__ endif