Re: [PATCH] Fix "identifier redeclared" compilation error with SUN cc

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 20, 2007, 08:30 UTC
Message-ID: <7vhcjhl3ni.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <Pine.LNX.4.64.0711191847550.7957@bianca.dialin.t-online.de>

Guido Ostkamp <git@ostkamp.fastmail.fm> writes:

Show 8 quoted lines

>> ...
>> How about doing it this way?
>
> it looks ok on Solaris. I assembled the following patch from your
> posting, could you please include it?
>
>
> Signed-off-by: Guido Ostkamp <git@ostkamp.fastmail.fm>

I knew it would work on Solaris with gcc and cc that do not understand flexible array members, but I am a bit worried about other environments, where flexible array members are properly supported. They've been happily using member[] but with the patch they suddenly start wasting a cell.

But we should do this sooner rather than later to find out any breakage, and give people on platforms with a cc that supports flexible array members and care about wasted memory enough time to send patches to support their compiler in the way similar to how gcc is supported.

But I cannot use your message with whitespace-broken patch (note "format=flawed") and insufficient commit log message, which means I have to do this myself. Not tonight...