Re: [PATCH] Fix Solaris Workshop Compiler issues

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 14, 2007, 21:25 UTC
Message-ID: <7vprycfrk6.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071114204732.GE3973@steel.home>

Alex Riesen <raa.lkml@gmail.com> writes:

Show 9 quoted lines

> Guido Ostkamp, Wed, Nov 14, 2007 21:31:13 +0100:
>> ...
>> cc: acomp failed for diff-delta.c
>> make: *** [diff-delta.o] Error 2
>>
>> This is because 'struct delta_index' is declared with no size in delta.h 
>> and with size in diff-delta.c which does not fit.
>
> Huh?! Ever heard of forward declaration?

We are not the first people who pass around a pointer to an opaque struct in the API to hide away the implementation. It would be surprising if the Workshop Compiler chokes on this and not other projects.