Re: [PATCH] Fix Solaris Workshop Compiler issues

From: Björn Steinbrink <b.steinbrink@gmx.de>
Date: Nov 15, 2007, 00:17 UTC
Message-ID: <20071115001756.GA25021@atjola.homenet>
In-Reply-To: <20071114232809.GH3973@steel.home>

On 2007.11.15 00:28:09 +0100, Alex Riesen wrote:

Show 14 quoted lines

> Guido Ostkamp, Thu, Nov 15, 2007 00:21:55 +0100:
> > The main difference is that the 'struct delta_index' is opaque in delta.h 
> > and non-opaque in diff-delta.c; the patch clearly shows it solves the 
> > error. So we've got a solution.
> 
> It is not the solution. How do you think the rest of Git compiles?
> 
> > If you feel we could try something else, please let me know and I'll check 
> > it out.
> 
> Yes. Read the mail I sent before:
> 
>     Try removing the "const". Looks like that compiler is too stupid
>     to understand it.

No, just tried with cc: Sun C 5.7 Patch 117837-06 2005/10/05

It's the "struct hack", ie. the incomplete array at the end of delta_index. Still looking for a fix/workaround.

Björn