Re: [PATCH 4/7] t/t5503-tagfollow: change from skip_all=* to prereq skip

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 11, 2010, 18:32 UTC
Message-ID: <7vtyn1xaom.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1281469968-25670-5-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 16 quoted lines

> diff --git a/t/t5503-tagfollow.sh b/t/t5503-tagfollow.sh
> index bab1a53..8a298a6 100755
> --- a/t/t5503-tagfollow.sh
> +++ b/t/t5503-tagfollow.sh
> @@ -6,8 +6,11 @@ test_description='test automatic tag following'
>  
>  case $(uname -s) in
>  *MINGW*)
> -	skip_all="GIT_DEBUG_SEND_PACK not supported - skipping tests"
> -	test_done
> +	say "GIT_DEBUG_SEND_PACK not supported - skipping tests"
> +	;;
> +*)
> +	test_set_prereq NOT_MINGW
> +	;;
>  esac

To Ævar; isn't the prerequisite for these tests "does our git support send pack debugging?" not "are we not running on mingw?" Let's call it DEBUG_SEND_PACK or something.

To J6t; does the assumption here still hold, or do we support send pack debugging these days?