[PATCH v2 0/7] tests: use skip_all=* to skip tests

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Aug 11, 2010, 19:04 UTC
Message-ID: <1281553450-26467-1-git-send-email-avarab@gmail.com>
In-Reply-To: <7vd3tpxao1.fsf@alter.siamese.dyndns.org>

On Wed, Aug 11, 2010 at 18:32, Junio C Hamano <gitster@pobox.com> wrote:

> Except for a few which I'll comment separately all of these looked
> reasonable (I didn't look at 7/7 very carefully, though).

Thanks for the review. Here's a v2 that fixes the isssues raised.

Like v1 aside from these fixes, all but one spotted by Junio:
    
    diff --git a/t/t1304-default-acl.sh b/t/t1304-default-acl.sh
    index 0e6cb4f..b5d89a2 100755
    --- a/t/t1304-default-acl.sh
    +++ b/t/t1304-default-acl.sh
    @@ -28 +27,0 @@ fi
    -
    diff --git a/t/t4016-diff-quote.sh b/t/t4016-diff-quote.sh
    index 10e2db3..ab0c2f0 100755
    --- a/t/t4016-diff-quote.sh
    +++ b/t/t4016-diff-quote.sh
    @@ -14 +14 @@ P2='pathname with SP'
    -if P3='pathname
    +P3='pathname
    @@ -16 +16 @@ with LF'
    -: 2>/dev/null >"$P1" && test -f "$P1" && rm -f "$P1"
    +if : 2>/dev/null >"$P1" && test -f "$P1" && rm -f "$P1"
    diff --git a/t/t5705-clone-2gb.sh b/t/t5705-clone-2gb.sh
    index 694e28d..e9783c3 100755
    --- a/t/t5705-clone-2gb.sh
    +++ b/t/t5705-clone-2gb.sh
    @@ -6 +6,6 @@ test_description='Test cloning a repository larger than 2 gigabyte'
    -test -n "$GIT_TEST_CLONE_2GB" && test_set_prereq CLONE_2GB
    +if test -z "$GIT_TEST_CLONE_2GB"
    +then
    +       say 'Skipping expensive 2GB clone test; enable it with GIT_TEST_CLONE_2GB=t'
    +else
    +       test_set_prereq CLONE_2GB
    +fi

Ævar Arnfjörð Bjarmason (7):
  t/t1304-default-acl: change from skip_all=* to prereq skip
  t/t5705-clone-2gb: change from skip_all=* to prereq skip
  t/t7005-editor: change from skip_all=* to prereq skip
  t/t5503-tagfollow: change from skip_all=* to prereq skip
  t/t4016-diff-quote: change from skip_all=* to prereq skip
  t/t3902-quoted: change from skip_all=* to prereq skip
  t/t3300-funny-names: change from skip_all=* to prereq skip

 t/t1304-default-acl.sh |   14 +++++---
 t/t3300-funny-names.sh |   82 +++++++++++++++++++++++++++++++++++-------------
 t/t3902-quoted.sh      |   38 ++++++++++++----------
 t/t4016-diff-quote.sh  |   22 +++++++++----
 t/t5503-tagfollow.sh   |   33 ++++++++++++++-----
 t/t5705-clone-2gb.sh   |   16 +++++----
 t/t7005-editor.sh      |   10 +++---
 7 files changed, 142 insertions(+), 73 deletions(-)

-- 
1.7.2.1.295.gdf931