git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/7] t/t5705-clone-2gb: change from skip_all=* to prereq skip

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Aug 11, 2010, 19:04 UTC
Message-ID
<1281553450-26467-3-git-send-email-avarab@gmail.com>
In-Reply-To
<7vd3tpxao1.fsf@alter.siamese.dyndns.org>

Change this test to skip test with test prerequisites, and to do setup work in tests. This improves the skipped statistics on platforms where the test isn't run.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 t/t5705-clone-2gb.sh |   16 +++++++++-------
 1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/t/t5705-clone-2gb.sh b/t/t5705-clone-2gb.sh
index e4d1b6a..e9783c3 100755
--- a/t/t5705-clone-2gb.sh
+++ b/t/t5705-clone-2gb.sh
@@ -3,12 +3,14 @@
 test_description='Test cloning a repository larger than 2 gigabyte'
 . ./test-lib.sh
 
-test -z "$GIT_TEST_CLONE_2GB" &&
-skip_all="Skipping expensive 2GB clone test; enable it with GIT_TEST_CLONE_2GB=t" &&
-test_done &&
-exit
+if test -z "$GIT_TEST_CLONE_2GB"
+then
+	say 'Skipping expensive 2GB clone test; enable it with GIT_TEST_CLONE_2GB=t'
+else
+	test_set_prereq CLONE_2GB
+fi
 
-test_expect_success 'setup' '
+test_expect_success CLONE_2GB 'setup' '
 
 	git config pack.compression 0 &&
 	git config pack.depth 0 &&
@@ -36,13 +38,13 @@ test_expect_success 'setup' '
 
 '
 
-test_expect_success 'clone - bare' '
+test_expect_success CLONE_2GB 'clone - bare' '
 
 	git clone --bare --no-hardlinks . clone-bare
 
 '
 
-test_expect_success 'clone - with worktree, file:// protocol' '
+test_expect_success CLONE_2GB 'clone - with worktree, file:// protocol' '
 
 	git clone file://. clone-wt
 
-- 
1.7.2.1.295.gdf931
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 20 of 25 in “tests: use skip_all=* to skip tests”
  1. 0/7 tests: use skip_all=* to skip testsÆvar Arnfjörð Bjarmason, Aug 10, 2010
  2. 1/7 t/t1304-default-acl: change from skip_all=* to prereq skipÆvar Arnfjörð Bjarmason, Aug 10, 2010
  3. 2/7 t/t5705-clone-2gb: change from skip_all=* to prereq skipÆvar Arnfjörð Bjarmason, Aug 10, 2010
  4. Junio C HamanoAug 11, 2010
  5. 3/7 t/t7005-editor: change from skip_all=* to prereq skipÆvar Arnfjörð Bjarmason, Aug 10, 2010
  6. 4/7 t/t5503-tagfollow: change from skip_all=* to prereq skipÆvar Arnfjörð Bjarmason, Aug 10, 2010
  7. Junio C HamanoAug 11, 2010
  8. Ævar Arnfjörð BjarmasonAug 11, 2010
  9. Junio C HamanoAug 12, 2010
  10. Johannes SixtAug 11, 2010
  11. 5/7 t/t4016-diff-quote: change from skip_all=* to prereq skipÆvar Arnfjörð Bjarmason, Aug 10, 2010
  12. Junio C HamanoAug 11, 2010
  13. 6/7 t/t3902-quoted: change from skip_all=* to prereq skipÆvar Arnfjörð Bjarmason, Aug 10, 2010
  14. 7/7 t/t3300-funny-names: change from skip_all=* to prereq skipÆvar Arnfjörð Bjarmason, Aug 10, 2010
  15. Junio C HamanoAug 11, 2010
  16. 0/7 tests: use skip_all=* to skip testsÆvar Arnfjörð Bjarmason, Aug 11, 2010
  17. case where diff output needs improving? (was Re: [PATCH v2 0/7] tests: use skip_all=* to skip tests)Raja R Harinath, Aug 12, 2010
  18. Ævar Arnfjörð BjarmasonAug 12, 2010
  19. 1/7 t/t1304-default-acl: change from skip_all=* to prereq skipÆvar Arnfjörð Bjarmason, Aug 11, 2010
  20. 2/7 t/t5705-clone-2gb: change from skip_all=* to prereq skipÆvar Arnfjörð Bjarmason, Aug 11, 2010
  21. 3/7 t/t7005-editor: change from skip_all=* to prereq skipÆvar Arnfjörð Bjarmason, Aug 11, 2010
  22. 4/7 t/t5503-tagfollow: change from skip_all=* to prereq skipÆvar Arnfjörð Bjarmason, Aug 11, 2010
  23. 5/7 t/t4016-diff-quote: change from skip_all=* to prereq skipÆvar Arnfjörð Bjarmason, Aug 11, 2010
  24. 6/7 t/t3902-quoted: change from skip_all=* to prereq skipÆvar Arnfjörð Bjarmason, Aug 11, 2010
  25. 7/7 t/t3300-funny-names: change from skip_all=* to prereq skipÆvar Arnfjörð Bjarmason, Aug 11, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.