Re: [PATCH 4/7] t/t5503-tagfollow: change from skip_all=* to prereq skip

From: Johannes Sixt <j6t@kdbg.org>
Date: Aug 11, 2010, 20:20 UTC
Message-ID: <201008112220.40864.j6t@kdbg.org>
In-Reply-To: <7vtyn1xaom.fsf@alter.siamese.dyndns.org>

On Mittwoch, 11. August 2010, Junio C Hamano wrote:

Show 24 quoted lines

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> > diff --git a/t/t5503-tagfollow.sh b/t/t5503-tagfollow.sh
> > index bab1a53..8a298a6 100755
> > --- a/t/t5503-tagfollow.sh
> > +++ b/t/t5503-tagfollow.sh
> > @@ -6,8 +6,11 @@ test_description='test automatic tag following'
> >
> >  case $(uname -s) in
> >  *MINGW*)
> > -	skip_all="GIT_DEBUG_SEND_PACK not supported - skipping tests"
> > -	test_done
> > +	say "GIT_DEBUG_SEND_PACK not supported - skipping tests"
> > +	;;
> > +*)
> > +	test_set_prereq NOT_MINGW
> > +	;;
> >  esac
>
> To Ævar; isn't the prerequisite for these tests "does our git support send
> pack debugging?" not "are we not running on mingw?"  Let's call it
> DEBUG_SEND_PACK or something.
>
> To J6t; does the assumption here still hold, or do we support send pack
> debugging these days?

GIT_DEBUG_SEND_PACK is still not supported on Windows.

-- Hannes