git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC 2/5] Pretty Print: show tz when using DATE_LOCAL

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 21, 2011, 22:34 UTC
Message-ID
<7vtydrutbq.fsf@alter.siamese.dyndns.org>
In-Reply-To
<acbcf231-e0a6-440e-be42-5f25da3e318d-mfwitten@gmail.com>
Michael Witten <mfwitten@gmail.com> writes:
> Date: Fri, 11 Feb 2011 16:06:36 +0000
> Currently, when the date mode is DATE_LOCAL, the
> time zone is never pretty printed;...

I am not opposed to have a new mode that shows timestamps in local timezone with zone information, but this change is a regression to people who have known and relied upon that asking for timestamps in their local timezone will give everything in the local timezone and result in a short output by the virtue of not needing to repeat the zone string, as they are the same (this is not strictly true near your dst boundary, and that is why I am open to the idea as a separate option).

This is a tangent but it is funny to see the unnecessary Date: in-body header for a series about date display. Please drop it.

Backdating the author timestamp will make it harder to find the related discussion from the list archive; the only plausible benefit I can see is that you may get "I thought of this much earlier than when I posted it to the public for the first time" pee-in-the-snow value out of doing so, but that is done at the cost to all others who need to inspect the history later. Please don't.

As a future reference, when you have a valid reason to override the header information your MUA would give your message with an in-body header, please leave a blank line after the in-body header to make the result easier to read, like this:

        Date: Fri, 11 Feb 2011 16:06:36 +0000
        Currently, when the date mode is DATE_LOCAL, the
        time zone is never pretty printed;...

Also paragraphs that wrap lines at too narrow a margin is just as hard to read as paragraphs wrapped at a margin that is too wide. You seem to have wrapped at around 50 columns?

Previous: Michael WittenNext: Michael Witten
Message 4 of 37 in “[RFC 0/5] Date Mode: Add --time-zone; deprecate --date=local”
  1. Michael WittenApr 20, 2011
  2. 1/5 Light refactoring of date infrastructureMichael Witten, Apr 20, 2011
  3. 2/5 Pretty Print: show tz when using DATE_LOCALMichael Witten, Apr 20, 2011
  4. Junio C HamanoApr 21, 2011
  5. Dates in Commits and other issues of style (Re: [RFC 2/5] Pretty Print: show tz when using DATE_LOCAL)Michael Witten, Apr 22, 2011
  6. Miles BaderApr 25, 2011
  7. Junio C HamanoApr 25, 2011
  8. Jakub NarebskiApr 25, 2011
  9. Junio C HamanoApr 25, 2011
  10. Michael WittenApr 22, 2011
  11. Junio C HamanoApr 22, 2011
  12. 3/5 Date Mode: ImplementationMichael Witten, Apr 20, 2011
  13. Junio C HamanoApr 21, 2011
  14. 4/5 Date Mode: DocumentationMichael Witten, Apr 20, 2011
  15. 5/5 Date Mode: TestsMichael Witten, Apr 20, 2011
  16. Junio C HamanoApr 21, 2011
  17. Michael WittenApr 23, 2011
  18. Michael WittenApr 23, 2011
  19. Time zone option name (Re: [RFC 5/5] Date Mode: Tests)Michael Witten, Apr 23, 2011
  20. Junio C HamanoApr 23, 2011
  21. Michael WittenApr 23, 2011
  22. Jeff KingApr 20, 2011
  23. Michael WittenApr 20, 2011
  24. Junio C HamanoApr 21, 2011
  25. Michael WittenApr 21, 2011
  26. Junio C HamanoApr 21, 2011
  27. Michael WittenApr 21, 2011
  28. Michael WittenApr 20, 2011
  29. Michael WittenApr 20, 2011
  30. Michael WittenApr 20, 2011
  31. Tabs and spaces (Re: [RFC 0/5] Date Mode: Add --time-zone; deprecate --date=local)Jonathan Nieder, Apr 21, 2011
  32. Michael WittenApr 21, 2011
  33. Jonathan NiederApr 21, 2011
  34. Michael WittenApr 21, 2011
  35. Thiago FarinaApr 21, 2011
  36. Alex RiesenApr 21, 2011
  37. Michael WittenApr 21, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.