Re: [RFC 2/5] Pretty Print: show tz when using DATE_LOCAL

From: Michael Witten <mfwitten@gmail.com>
Date: Apr 22, 2011, 14:36 UTC
Message-ID: <08195d5d-bd90-49d3-a1a6-63be0d833110-mfwitten@gmail.com>
In-Reply-To: <7vtydrutbq.fsf@alter.siamese.dyndns.org>

On Thu, 21 Apr 2011 15:34:49 -0700, Junio C Hamano wrote:

Show 13 quoted lines

> Michael Witten <mfwitten@gmail.com> writes:
>
>> Date: Fri, 11 Feb 2011 16:06:36 +0000
>> Currently, when the date mode is DATE_LOCAL, the
>> time zone is never pretty printed;...
>
> I am not opposed to have a new mode that shows timestamps in local
> timezone with zone information, but this change is a regression to people
> who have known and relied upon that asking for timestamps in their local
> timezone will give everything in the local timezone and result in a short
> output by the virtue of not needing to repeat the zone string, as they are
> the same (this is not strictly true near your dst boundary, and that is
> why I am open to the idea as a separate option).

Allow me to restate what I think you are saying:

How about having [the still deprecated] --date=local (that is, DATE_LOCAL) option produce the old behavior, but have every combination of date mode options that does not involve DATE_LOCAL always emit the time zone.

In other words, all of these do not emit a time zone:

  --date=local
  --date=local --time-zone=local
  --date=local --time-zone=default   # --time-zone is ignored for simplicity.

and all of these always emit a time zone:

  --date=default
  --date=rfc
  --date=rfc2822
  --date=iso
  --date=iso8601
  --date=short
  --date=raw
  --date=default --time-zone=default
  --date=rfc     --time-zone=default
  --date=rfc2822 --time-zone=default
  --date=iso     --time-zone=default
  --date=iso8601 --time-zone=default
  --date=short   --time-zone=default
  --date=raw     --time-zone=default
  --date=default --time-zone=local
  --date=rfc2822 --time-zone=local
  --date=rfc     --time-zone=local
  --date=iso     --time-zone=local
  --date=iso8601 --time-zone=local
  --date=short   --time-zone=local
  --date=raw     --time-zone=local
                 --time-zone=local
                 --time-zone=default