Time zone option name (Re: [RFC 5/5] Date Mode: Tests)
- From
Michael Witten <mfwitten@gmail.com>
- Date
- Apr 23, 2011, 03:45 UTC
- Message-ID
- <453b72ab-40cc-431b-9865-3080c250a7dd-mfwitten@gmail.com>
- In-Reply-To
- <7vd3kfusva.fsf@alter.siamese.dyndns.org>
On Thu, 21 Apr 2011 15:44:41 -0700, Junio C Hamano wrote:
Show 8 quoted lines
> I'd like to have part of the tests in this patch at the beginning of the > series to document and protect the behaviour of the current --date related > options, then your enhancement that adds --zone that lets the users > specify the timezone and the format independently, and finally the > remainder of this patch as an addition to the test script to document and > protect the interaction between the two options (e.g. what happens when > none or only one is specified? what happens when conflicting options such > as "--date=local --zone=gmt" is given?).
I'd like to clarify what you intend the new time zone option to be named; my patch series currently uses `--time-zone' (which is admittedly long), but it would appear here that you find `--zone' attractive. My only qualm there is that `zone' is such a rich word; not only is it somewhat incomprehensible out of context, but it also might be useful for something else in the future.