git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Tabs and spaces

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Apr 21, 2011, 02:18 UTC
Message-ID
<20110421021825.GA23373@elie>
In-Reply-To
<1235e29d-6cbb-445b-9b6f-4e174c03ba8f-mfwitten@gmail.com>
Michael Witten wrote:
> You just need an editor that [...]

which many contributors don't have (or haven't configured that way). Really.

[...]
Show 14 quoted lines
> However, with a tabstop of 2, it looks like this:
>
>   if (foo && bar && baz &&
>       qux && quux) {
>     ...
>   } else if (quuux(quuuux, quuuuux,
>         long_expresion_comes_here(quuuuuux))) {
>     ...
>   }
>
> Notice that your `qux && quux' line (which follows the method we both like)
> remained nicely aligned, but your `long_expression_comes_here' line has
> moved back so much that it doesn't even satisfy the `right margin' rule
> anymore.

Oh, I still think a tabstop of 2 is insane (for various reasons, some explained in the thread you mentioned).

No matter --- Junio will use --whitespace=fixup to convert your spaces to tabs anyway. Just thought I could give some survival tips.

Regards, Jonathan

Previous: Michael WittenNext: Michael Witten
Message 33 of 37 in “[RFC 0/5] Date Mode: Add --time-zone; deprecate --date=local”
  1. Michael WittenApr 20, 2011
  2. 1/5 Light refactoring of date infrastructureMichael Witten, Apr 20, 2011
  3. 2/5 Pretty Print: show tz when using DATE_LOCALMichael Witten, Apr 20, 2011
  4. Junio C HamanoApr 21, 2011
  5. Dates in Commits and other issues of style (Re: [RFC 2/5] Pretty Print: show tz when using DATE_LOCAL)Michael Witten, Apr 22, 2011
  6. Miles BaderApr 25, 2011
  7. Junio C HamanoApr 25, 2011
  8. Jakub NarebskiApr 25, 2011
  9. Junio C HamanoApr 25, 2011
  10. Michael WittenApr 22, 2011
  11. Junio C HamanoApr 22, 2011
  12. 3/5 Date Mode: ImplementationMichael Witten, Apr 20, 2011
  13. Junio C HamanoApr 21, 2011
  14. 4/5 Date Mode: DocumentationMichael Witten, Apr 20, 2011
  15. 5/5 Date Mode: TestsMichael Witten, Apr 20, 2011
  16. Junio C HamanoApr 21, 2011
  17. Michael WittenApr 23, 2011
  18. Michael WittenApr 23, 2011
  19. Time zone option name (Re: [RFC 5/5] Date Mode: Tests)Michael Witten, Apr 23, 2011
  20. Junio C HamanoApr 23, 2011
  21. Michael WittenApr 23, 2011
  22. Jeff KingApr 20, 2011
  23. Michael WittenApr 20, 2011
  24. Junio C HamanoApr 21, 2011
  25. Michael WittenApr 21, 2011
  26. Junio C HamanoApr 21, 2011
  27. Michael WittenApr 21, 2011
  28. Michael WittenApr 20, 2011
  29. Michael WittenApr 20, 2011
  30. Michael WittenApr 20, 2011
  31. Tabs and spaces (Re: [RFC 0/5] Date Mode: Add --time-zone; deprecate --date=local)Jonathan Nieder, Apr 21, 2011
  32. Michael WittenApr 21, 2011
  33. Jonathan NiederApr 21, 2011
  34. Michael WittenApr 21, 2011
  35. Thiago FarinaApr 21, 2011
  36. Alex RiesenApr 21, 2011
  37. Michael WittenApr 21, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.