git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: gitk: Failure of new tabbed preferences dialog

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 2, 2012, 16:19 UTC
Message-ID
<7vty12gl8r.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1333317652-1464-1-git-send-email-patthoyts@users.sourceforge.net>
Pat Thoyts <patthoyts@users.sourceforge.net> writes:
Show 11 quoted lines
>> I just tried the new gitk (master @fae9d76) and, since I don't have
>> themed widgets, the preferences menu item uses the emulated tabbed
>> dialog code, which fails like so:
>>
>>     can't read "col": no such variable
>
> The issue here is that the incr command has changed between tcl 8.4
> and 8.5 and in more recent versions automatically creates the named
> variable if it did not exist. The fix you suggest is correct. I've
> also included another that I realised had been applied to msysGit and
> was not posted upstream.

This seems severe enough that we should put it in the coming release. I can queue them directory to gitk tree (and later ask Paul to pull it from me), and merge the result to expedite the roundtrip.

Previous: Pat ThoytsNext: Junio C Hamano
Message 5 of 8 in “gitk: Failure of new tabbed preferences dialog”
  1. Ramsay JonesMar 29, 2012
  2. Pat ThoytsApr 1, 2012
  3. 1/2 gitk: fix tabbed preferences construction when using tcl 8.4Pat Thoyts, Apr 1, 2012
  4. 2/2 gitk: fix setting font display with new tabbed dialog layout.Pat Thoyts, Apr 1, 2012
  5. Junio C HamanoApr 2, 2012
  6. Junio C HamanoApr 2, 2012
  7. Paul MackerrasApr 3, 2012
  8. Junio C HamanoApr 3, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.