git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: gitk: Failure of new tabbed preferences dialog

From
Paul Mackerras <paulus@samba.org>
Date
Apr 3, 2012, 12:19 UTC
Message-ID
<20120403121944.GC24141@bloggs.ozlabs.ibm.com>
In-Reply-To
<7vty12gl8r.fsf@alter.siamese.dyndns.org>
On Mon, Apr 02, 2012 at 09:19:00AM -0700, Junio C Hamano wrote:
Show 17 quoted lines
> Pat Thoyts <patthoyts@users.sourceforge.net> writes:
> 
> >> I just tried the new gitk (master @fae9d76) and, since I don't have
> >> themed widgets, the preferences menu item uses the emulated tabbed
> >> dialog code, which fails like so:
> >>
> >>     can't read "col": no such variable
> >
> > The issue here is that the incr command has changed between tcl 8.4
> > and 8.5 and in more recent versions automatically creates the named
> > variable if it did not exist. The fix you suggest is correct. I've
> > also included another that I realised had been applied to msysGit and
> > was not posted upstream.
> 
> This seems severe enough that we should put it in the coming release.
> I can queue them directory to gitk tree (and later ask Paul to pull it
> from me), and merge the result to expedite the roundtrip.

OK; the patches look fine to me. If that's what you're doing, I won't apply them to my tree, to avoid duplication.

Paul.
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 8 in “gitk: Failure of new tabbed preferences dialog”
  1. Ramsay JonesMar 29, 2012
  2. Pat ThoytsApr 1, 2012
  3. 1/2 gitk: fix tabbed preferences construction when using tcl 8.4Pat Thoyts, Apr 1, 2012
  4. 2/2 gitk: fix setting font display with new tabbed dialog layout.Pat Thoyts, Apr 1, 2012
  5. Junio C HamanoApr 2, 2012
  6. Junio C HamanoApr 2, 2012
  7. Paul MackerrasApr 3, 2012
  8. Junio C HamanoApr 3, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.