From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 02 Apr 2012 16:19:00 GMT
Subject: Re: gitk: Failure of new tabbed preferences dialog
Message-ID: <7vty12gl8r.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1333317652-1464-1-git-send-email-patthoyts@users.sourceforge.net>

Pat Thoyts <patthoyts@users.sourceforge.net> writes:

>> I just tried the new gitk (master @fae9d76) and, since I don't have
>> themed widgets, the preferences menu item uses the emulated tabbed
>> dialog code, which fails like so:
>>
>>     can't read "col": no such variable
>
> The issue here is that the incr command has changed between tcl 8.4
> and 8.5 and in more recent versions automatically creates the named
> variable if it did not exist. The fix you suggest is correct. I've
> also included another that I realised had been applied to msysGit and
> was not posted upstream.

This seems severe enough that we should put it in the coming release.
I can queue them directory to gitk tree (and later ask Paul to pull it
from me), and merge the result to expedite the roundtrip.