git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] gitk: fix tabbed preferences construction when using tcl 8.4

From
Pat Thoyts <patthoyts@users.sourceforge.net>
Date
Apr 1, 2012, 22:00 UTC
Message-ID
<1333317652-1464-2-git-send-email-patthoyts@users.sourceforge.net>
In-Reply-To
<1333317652-1464-1-git-send-email-patthoyts@users.sourceforge.net>

In 8.5 the incr command creates the target variable if it does not exist but in 8.4 using incr on a non-existing variable raises an error. Ensure we have created our counter variable when creating the tabbed dialog for non-themed preferences.

Reported-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
---
 gitk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gitk b/gitk
index 651b740..68cd1a1 100755
--- a/gitk
+++ b/gitk
@@ -11012,6 +11012,7 @@ proc doprefs {} {
     lappend pages [prefspage_general $notebook] [mc "General"]
     lappend pages [prefspage_colors $notebook] [mc "Colors"]
     lappend pages [prefspage_fonts $notebook] [mc "Fonts"]
+    set col 0
     foreach {page title} $pages {
 	if {$use_notebook} {
 	    $notebook add $page -text $title
-- 
1.7.9.msysgit.0
Previous: Pat ThoytsNext: Pat Thoyts
Message 3 of 8 in “gitk: Failure of new tabbed preferences dialog”
  1. Ramsay JonesMar 29, 2012
  2. Pat ThoytsApr 1, 2012
  3. 1/2 gitk: fix tabbed preferences construction when using tcl 8.4Pat Thoyts, Apr 1, 2012
  4. 2/2 gitk: fix setting font display with new tabbed dialog layout.Pat Thoyts, Apr 1, 2012
  5. Junio C HamanoApr 2, 2012
  6. Junio C HamanoApr 2, 2012
  7. Paul MackerrasApr 3, 2012
  8. Junio C HamanoApr 3, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.