Re: [PATCH] rev-parse --show-prefix: add in trailing newline

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 10, 2012, 17:56 UTC
Message-ID: <7vty0rpj2i.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120410173616.GA4300@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 18 quoted lines

> (cc-ing Duy)
> Hi,
>
> Ross Lagerwall wrote:
>
>> --- a/builtin/rev-parse.c
>> +++ b/builtin/rev-parse.c
>> @@ -634,6 +634,8 @@ int cmd_rev_parse(int argc, const char **argv, const char *prefix)
>>  			if (!strcmp(arg, "--show-prefix")) {
>>  				if (prefix)
>>  					puts(prefix);
>> +				else
>> +					putchar('\n');
>>  				continue;
>
> This makes the output more consistent but it is a little puzzling how
> it does that.  Why is prefix NULL instead of "" when we are at the
> toplevel of the worktree?

Interesting point ;-)