git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rev-parse --show-prefix: add in trailing newline

From
Ross Lagerwall <rosslagerwall@gmail.com>
Date
Apr 10, 2012, 05:30 UTC
Message-ID
<4F83C589.20609@gmail.com>
In-Reply-To
<7v1unwwwov.fsf@alter.siamese.dyndns.org>
On 2012/04/09 21:07, Junio C Hamano wrote:
Show 7 quoted lines
> fc68875 (t1501 (rev-parse): clarify, 2010-07-24) says it is a "possible
> bug", but I do not think the expectation of the new test added by that
> commit is entirely correct.
>
> Because the assignment will strip the trailing LF away adding an extra
> newline at the end would not matter in practice in many scripts, e.g.
>

True, and the current behavior does exactly what the man page says: "When the command is invoked from a subdirectory, show the path of the current directory relative to the top-level directory."

So then perhaps the test should be removed?

Also, --show-cdup has a similar description for the man page but does output a newline when invoked from the root dir. Should this behavior be made consistent?

-- 
Ross Lagerwall
Previous: Junio C HamanoNext: Jonathan Nieder
Message 3 of 9 in “rev-parse --show-prefix: add in trailing newline”
  1. rev-parse --show-prefix: add in trailing newlineRoss Lagerwall, Apr 9, 2012
  2. Junio C HamanoApr 9, 2012
  3. Ross LagerwallApr 10, 2012
  4. Jonathan NiederApr 10, 2012
  5. Andreas SchwabApr 10, 2012
  6. Junio C HamanoApr 10, 2012
  7. Jonathan NiederApr 10, 2012
  8. Junio C HamanoApr 10, 2012
  9. Nguyen Thai Ngoc DuyApr 10, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.