git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] rev-parse --show-prefix: add in trailing newline

From
Ross Lagerwall <rosslagerwall@gmail.com>
Date
Apr 9, 2012, 13:27 UTC
Message-ID
<1333978076-29968-1-git-send-email-rosslagerwall@gmail.com>

Print out a trailing newline when --show-prefix is run with cwd at the top level of the tree which results in an empty prefix. Behavior is now like --show-cdup.

Fixes an expected failure in t1501.
Signed-off-by: Ross Lagerwall <rosslagerwall@gmail.com>
---
 builtin/rev-parse.c |    2 ++
 t/t1501-worktree.sh |    2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/builtin/rev-parse.c b/builtin/rev-parse.c
index 98d1cbe..733f626 100644
--- a/builtin/rev-parse.c
+++ b/builtin/rev-parse.c
@@ -634,6 +634,8 @@ int cmd_rev_parse(int argc, const char **argv, const char *prefix)
 			if (!strcmp(arg, "--show-prefix")) {
 				if (prefix)
 					puts(prefix);
+				else
+					putchar('\n');
 				continue;
 			}
 			if (!strcmp(arg, "--show-cdup")) {
diff --git a/t/t1501-worktree.sh b/t/t1501-worktree.sh
index e661147..8f36aa9 100755
--- a/t/t1501-worktree.sh
+++ b/t/t1501-worktree.sh
@@ -68,7 +68,7 @@ test_expect_success 'inside work tree' '
 	)
 '
 
-test_expect_failure 'empty prefix is actually written out' '
+test_expect_success 'empty prefix is actually written out' '
 	echo >expected &&
 	(
 		cd work &&
-- 
1.7.10
Next: Junio C Hamano
Message 1 of 9 in “rev-parse --show-prefix: add in trailing newline”
  1. rev-parse --show-prefix: add in trailing newlineRoss Lagerwall, Apr 9, 2012
  2. Junio C HamanoApr 9, 2012
  3. Ross LagerwallApr 10, 2012
  4. Jonathan NiederApr 10, 2012
  5. Andreas SchwabApr 10, 2012
  6. Junio C HamanoApr 10, 2012
  7. Jonathan NiederApr 10, 2012
  8. Junio C HamanoApr 10, 2012
  9. Nguyen Thai Ngoc DuyApr 10, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.