Re: FEATURE REQUEST: git-format-path: Add option to encode patch content

Jari Aalto <jari.aalto@cante.net> writes:

One possibility is to have a separate mail sending or formatting program that works on format-patch output. In any case, I feel that _generating_ base64 natively does not belong to core git. We _tolerate_ MIME in mailinfo, but that does not mean we encourage MIME. Keeping patches reviewable in recipient's MUA is important.

Now, after having given the "official" party-line answer, I personally think it would make sense to always do base64 when attaching the patch (i.e. "--attach", not "--inline").

In the community git originates from, even --inline attachments are frowned upon, let alone --attach multiparts (yes, I am talking about the kernel list and this list). Nobody who sends patches over e-mail in communities that have a tradition against unreadable patches would be using --inline nor --attach anyway, so making --attach to do base64 would not hurt there.

On the other hand, in circles whose recipients are prepared to (or even "prefer to") accept messages formatted with --attach, there should be no harm done if the patch text is base64 encoded either.

Am I going to do it? Not likely. But if a patch is cleanly done, I do not think there is much reason to reject one.