git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Re-re-re-fix common tail optimization

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 17, 2007, 17:58 UTC
Message-ID
<7vsl218aqd.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<Pine.LNX.4.64.0712171250550.9446@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 19 quoted lines
>> >> But as at least one released version of GNU diff has a pretty serious
>> >> bug,
>> >> I would rather not rely too much on diff.  (BTW this was the reason I
>> >> wanted --no-index so badly.)
>> >>
>> >> So yeah, the second "diff" cannot be "git diff".  Maybe "cmp", but not
>> >> "git diff".
>> > 
>> > Well cmp would be fine as well, seeing all we want is a boolean "is 
>> > this the same or not" answer. (I'm not familiar with the GNU diff bug 
>> > you speak of, but was it so bad that it couldn't even get *that* 
>> > answer right?)
>> 
>> Heh, there's at least one distribution out there (Suse 10.1) that comes 
>> with a *cmp* that doesn't get that answer right if its output is 
>> connected to /dev/null, which is the case when you simply 'make test'.
>
> Yeah.  That's what it was.  I even posted a patch to GNU diff, only to 
> find out that it was already fixed in CVS.  Sigh.

Wait. Are you still talking about diff or cmp, or are you saying that your earlier statement about avoiding GNU diff due to its bugs is unfounded?

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 22 of 30 in “trim_common_tail bug?”
  1. Jeff KingDec 15, 2007
  2. Jeff KingDec 15, 2007
  3. Junio C HamanoDec 15, 2007
  4. Jeff KingDec 15, 2007
  5. Jeff KingDec 16, 2007
  6. Junio C HamanoDec 16, 2007
  7. Junio C HamanoDec 16, 2007
  8. Jeff KingDec 16, 2007
  9. Re-re-re-fix common tail optimizationJunio C Hamano, Dec 16, 2007
  10. Jeff KingDec 16, 2007
  11. Junio C HamanoDec 16, 2007
  12. Junio C HamanoDec 16, 2007
  13. Jeff KingDec 16, 2007
  14. Wincent ColaiutaDec 17, 2007
  15. Johannes SchindelinDec 17, 2007
  16. Wincent ColaiutaDec 17, 2007
  17. Johannes SchindelinDec 17, 2007
  18. Wincent ColaiutaDec 17, 2007
  19. Jeff KingDec 17, 2007
  20. Johannes SixtDec 17, 2007
  21. Johannes SchindelinDec 17, 2007
  22. Junio C HamanoDec 17, 2007
  23. Johannes SchindelinDec 17, 2007
  24. Charles BaileyDec 19, 2007
  25. Jeff KingDec 19, 2007
  26. Charles BaileyDec 19, 2007
  27. Junio C HamanoDec 20, 2007
  28. Wincent ColaiutaDec 20, 2007
  29. Charles BaileyDec 20, 2007
  30. Junio C HamanoDec 20, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.