Re: [PATCH] Re-re-re-fix common tail optimization
- From
Jeff King <peff@peff.net>
- Date
- Dec 17, 2007, 12:12 UTC
- Message-ID
- <20071217121209.GA15368@coredump.intra.peff.net>
- In-Reply-To
- <57245FA1-361B-4333-B490-A2CC99ED4F9C@wincent.com>
On Mon, Dec 17, 2007 at 01:08:45PM +0100, Wincent Colaiuta wrote:
Show 6 quoted lines
>> So yeah, the second "diff" cannot be "git diff". Maybe "cmp", but not >> "git diff". > > Well cmp would be fine as well, seeing all we want is a boolean "is this the > same or not" answer. (I'm not familiar with the GNU diff bug you speak of, > but was it so bad that it couldn't even get *that* answer right?)
Personally I find it useful to generate the diff output when viewing with "-v". But if there is a real reason to use cmp over diff in the script, one can always manually go into the trash directory and run diff.
-Peff