Re: [PATCH] Re-re-re-fix common tail optimization

From: Charles Bailey <charles@hashpling.org>
Date: Dec 19, 2007, 14:18 UTC
Message-ID: <20071219141845.GA2146@hashpling.org>
In-Reply-To: <7v3au2joo2.fsf_-_@gitster.siamese.dyndns.org>

On Sun, Dec 16, 2007 at 01:49:17PM -0800, Junio C Hamano wrote:

Show 12 quoted lines

> 
> Kind'a embarrassing that both of us cannot get this right without so
> many rounds, isn't it?
> 
> -- >8 --
> Subject: [PATCH] Re-re-re-fix common tail optimization
> 
> We need to be extra careful recovering the removed common section, so
> that we do not break context nor the changed incomplete line (i.e. the
> last line that does not end with LF).
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Just to add to the woe on this one, this test breaks on MacOS X due to the pattern length limitations of the default sed on that platform.

Interested in a patch?

Charles.