Re: [PATCH] Re-re-re-fix common tail optimization

From: Jeff King <peff@peff.net>
Date: Dec 16, 2007, 22:29 UTC
Message-ID: <20071216222919.GA2260@coredump.intra.peff.net>
In-Reply-To: <7vtzmii8io.fsf@gitster.siamese.dyndns.org>

On Sun, Dec 16, 2007 at 02:23:27PM -0800, Junio C Hamano wrote:

> Yeah, I amended it without adding another "re-" to the title ;-)  The
> result has been already pushed out.

OK. Too late, but it has my ack. ;)

Show 7 quoted lines

> > Aren't we using "git diff" for the second diff there nowadays?
> 
> Some people seem to think that is a good idea, but I generally do not
> like using "git diff" between expect and actual (both untracked) inside
> tests.  The last "diff" is about validating what git does and using "git
> diff" there would make the test meaningless when "git diff" itself is
> broken.

I think that is a valid concern. But ISTR that were some issues with using GNU diff. Commit 5bd74506 mentions getting rid of the dependency in all existing tests, but gives no reason.

-Peff