git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] get_pathspec(): die when an out-of-tree path is given

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 7, 2008, 18:51 UTC
Message-ID
<7vskz21i7f.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<200803071929.42499.robin.rosenberg@dewire.com>
Robin Rosenberg <robin.rosenberg@dewire.com> writes:
> My gcc refuses to cooperate, giving me SEGV at line 666 or combine-diff, so 
> I'll ask instead of testing.
>
> Do absolute paths to diff still work without exiting?
They should, as long as they name inside work tree paths.

As far as I know, the bolted-on "work on files outside" code does not feed the paths to get_pathspec() (and it shouldn't --- that mode is not a git operation to begin with, and should work even without having a work tree, so there is no valid base to make the paths relative to).

But it needs to be checked.
Previous: Robin RosenbergNext: Johannes Schindelin
Message 4 of 7 in “Re-fix get_pathspec()”
  1. 0/4 Re-fix get_pathspec()Junio C Hamano, Mar 7, 2008
  2. 1/4 get_pathspec(): die when an out-of-tree path is givenJunio C Hamano, Mar 7, 2008
  3. Robin RosenbergMar 7, 2008
  4. Junio C HamanoMar 7, 2008
  5. Johannes SchindelinMar 7, 2008
  6. Junio C HamanoMar 7, 2008
  7. Junio C HamanoMar 8, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.