From: Junio C Hamano Date: Fri, 07 Mar 2008 18:51:00 GMT Subject: Re: [PATCH 1/4] get_pathspec(): die when an out-of-tree path is given Message-ID: <7vskz21i7f.fsf@gitster.siamese.dyndns.org> In-Reply-To: <200803071929.42499.robin.rosenberg@dewire.com> Robin Rosenberg writes: > My gcc refuses to cooperate, giving me SEGV at line 666 or combine-diff, so > I'll ask instead of testing. > > Do absolute paths to diff still work without exiting? They should, as long as they name inside work tree paths. As far as I know, the bolted-on "work on files outside" code does not feed the paths to get_pathspec() (and it shouldn't --- that mode is not a git operation to begin with, and should work even without having a work tree, so there is no valid base to make the paths relative to). But it needs to be checked.