git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] Re-fix get_pathspec()

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 7, 2008, 11:53 UTC
Message-ID
<alpine.LSU.1.00.0803071252240.19395@racer.site>
In-Reply-To
<1204879119-7528-1-git-send-email-gitster@pobox.com>
Hi,
On Fri, 7 Mar 2008, Junio C Hamano wrote:
Show 13 quoted lines
> After 1.5.4, we improved get_pathspec() to allow absolute paths, because
> people wanted to cut&paste from file managers and such, so that you can
> feed absolute paths to "git add" and friends.
> 
> However, the paths still must be inside work tree, so there must be a 
> way to ensure that.  d089eba (setup: sanitize absolute and funny paths 
> in get_pathspec()) botched the interface, by making the check the 
> responsibility of the callers, while keeping the interface to the 
> function intact, which meant that the callers needed to count returned 
> pathspecs and compared it with the number of paths fed to the function.
> 
> This miniseries cleans up the interface by making get_pathspec() to die
> again.

We have a few places where you have to pass a "die_on_error" flag. Why not imitate that?

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 7 in “Re-fix get_pathspec()”
  1. 0/4 Re-fix get_pathspec()Junio C Hamano, Mar 7, 2008
  2. 1/4 get_pathspec(): die when an out-of-tree path is givenJunio C Hamano, Mar 7, 2008
  3. Robin RosenbergMar 7, 2008
  4. Junio C HamanoMar 7, 2008
  5. Johannes SchindelinMar 7, 2008
  6. Junio C HamanoMar 7, 2008
  7. Junio C HamanoMar 8, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.