git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] Re-fix get_pathspec()

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 7, 2008, 17:48 UTC
Message-ID
<7v1w6m2zoq.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.LSU.1.00.0803071252240.19395@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 7 quoted lines
> On Fri, 7 Mar 2008, Junio C Hamano wrote:
>
>> This miniseries cleans up the interface by making get_pathspec() to die
>> again.
>
> We have a few places where you have to pass a "die_on_error" flag.  Why 
> not imitate that?

Before get_pathspec() was made absolute-path capable, it died on a path that is outside the work tree, so we know die() there is what the callers have expected all along. This miniseries is about fixing the earlier one that broke that expectation, nothing more.

If enough callers want different behaviours on error, it probably is worth an API enhancement so that the callers can choose to do their own thing, but that is a separate topic I haven't seen the need for, and definitely is not part of this fix.

Previous: Johannes SchindelinNext: Junio C Hamano
Message 6 of 7 in “Re-fix get_pathspec()”
  1. 0/4 Re-fix get_pathspec()Junio C Hamano, Mar 7, 2008
  2. 1/4 get_pathspec(): die when an out-of-tree path is givenJunio C Hamano, Mar 7, 2008
  3. Robin RosenbergMar 7, 2008
  4. Junio C HamanoMar 7, 2008
  5. Johannes SchindelinMar 7, 2008
  6. Junio C HamanoMar 7, 2008
  7. Junio C HamanoMar 8, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.