Re: [PATCH] sha1_file: make sure correct error is propagated

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 15, 2008, 05:44 UTC
Message-ID: <7vr65d7dct.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <200811142009.51803.fg@one2team.com>

Francis Galiegue <fg@one2team.com> writes:

Show 19 quoted lines

> Le Friday 14 November 2008 20:05:19 Junio C Hamano, vous avez écrit :
> [...]
>> >  	fd = mkstemp(buffer);
>> > -	if (fd < 0 && dirlen && (errno != EPERM)) {
>> > +	if (fd < 0 && dirlen && (errno != EACCESS)) {
>>
>> Is this accepting the two as equivalents???
>> --
>> To unsubscribe from this list: send the line "unsubscribe git" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> Well, looking at mkdir(2), it says:
>
>        EPERM  The file system containing pathname does not support the 
> creation of directories.
>
> Hmm, err... git would fail at an earlier point anyway, wouldn't it? Even git 
> init would fail there.

Actually, POSIX does not even talk about EPERM for mkdir(2), but that was not my point. The code does something different from what the proposed commit log message talks about. That was what bothered me.