Re: [PATCH] sha1_file: make sure correct error is propagated

From: Andreas Ericsson <ae@op5.se>
Date: Nov 14, 2008, 19:50 UTC
Message-ID: <491DD671.8070801@op5.se>
In-Reply-To: <200811142009.51803.fg@one2team.com>

Francis Galiegue wrote:

Show 19 quoted lines

> Le Friday 14 November 2008 20:05:19 Junio C Hamano, vous avez écrit :
> [...]
>>>  	fd = mkstemp(buffer);
>>> -	if (fd < 0 && dirlen && (errno != EPERM)) {
>>> +	if (fd < 0 && dirlen && (errno != EACCESS)) {
>> Is this accepting the two as equivalents???
>> --
>> To unsubscribe from this list: send the line "unsubscribe git" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> Well, looking at mkdir(2), it says:
> 
>        EPERM  The file system containing pathname does not support the 
> creation of directories.
> 
> Hmm, err... git would fail at an earlier point anyway, wouldn't it? Even git 
> init would fail there.
>

Not necessarily. .git could be mounted erroneously from via a networked filesystem but without write permissions. Yes, other things would fail then too, but both EPERM and EACCESS are valid and possible return codes.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231