Re: [PATCH] sha1_file: make sure correct error is propagated
- From
Sam Vilain <sam@vilain.net>
- Date
- Nov 15, 2008, 06:30 UTC
- Message-ID
- <1226730623.26334.2.camel@maia.lan>
- In-Reply-To
- <7vr65d7dct.fsf@gitster.siamese.dyndns.org>
On Fri, 2008-11-14 at 21:44 -0800, Junio C Hamano wrote:
> Actually, POSIX does not even talk about EPERM for mkdir(2), but that was > not my point. The code does something different from what the proposed > commit log message talks about. That was what bothered me.
My wording was a little terse and confusing. Here's a new one;
Subject: sha1_file.c: resolve confusion EACCESS vs EPERM
EPERM or 'Operation not permitted' is an unlikely error from mkstemp(); test for EACCESS 'Access Denied' instead. Make the special branch which prints the error to the user nicely also understand EACCESS.