Re: [PATCH] sha1_file: make sure correct error is propagated

From: Francis Galiegue <fg@one2team.com>
Date: Nov 14, 2008, 19:09 UTC
Message-ID: <200811142009.51803.fg@one2team.com>
In-Reply-To: <7vfxlu9lhs.fsf@gitster.siamese.dyndns.org>

Le Friday 14 November 2008 20:05:19 Junio C Hamano, vous avez écrit : [...]

Show 9 quoted lines

> >  	fd = mkstemp(buffer);
> > -	if (fd < 0 && dirlen && (errno != EPERM)) {
> > +	if (fd < 0 && dirlen && (errno != EACCESS)) {
>
> Is this accepting the two as equivalents???
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Well, looking at mkdir(2), it says:

       EPERM  The file system containing pathname does not support the 
creation of directories.

Hmm, err... git would fail at an earlier point anyway, wouldn't it? Even git init would fail there.

-- 
Francis Galiegue
ONE2TEAM
Ingénieur système
Mob : +33 (0) 6 83 87 78 75
Tel : +33 (0) 1 78 94 55 52
fge@one2team.com
40 avenue Raymond Poincaré
75116 Paris