Re: [PATCH 2/3] strbuf_nested_expand(): allow expansion to interrupt in the middle

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 16, 2009, 17:22 UTC
Message-ID: <7vr5t3uuca.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.1.00.0910161329270.4985@pacific.mpi-cbg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 9 quoted lines

> On Fri, 16 Oct 2009, Junio C Hamano wrote:
>
>>  		consumed = fn(sb, format, context);
>> -		if (consumed)
>> +		if ((ssize_t) consumed < 0)
>> +			break;
>
> Would it not be much better to fix the signature of fn in a separate 
> commit before this one?

Yes, I considered it and it is a reasonable thing to do if this were to become a real series for includion, but I thought it would add unnecessary noise to the patch when the main purpose of posting the series is still to be a proof-of-concept for discussing the design and future directions (including "it should not have any future---it is useless code churn for supporting only one example user 'rewrap'").

Please remind and yell at me if (1) this turns out to be going in the right direction and (2) I forget to fix it when I redo the series after discussion to apply them for real.

Thanks.