Re: [PATCH 3/3] Add proof-of-concept %[w(width,in1,in2)<<any-string>>%] implementation

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 16, 2009, 17:25 UTC
Message-ID: <7vk4yvuu79.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.1.00.0910161331350.4985@pacific.mpi-cbg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> maybe "rewrap" would be a better name than "w"?

Perhaps, but I do not know if wrap() is even better. The only reason I said w() here is because I saw you used w() and this is meant to be a superset replacement for it, as this can re-wrap anything, not just one particular field from the commit object.

Show 10 quoted lines

> On Fri, 16 Oct 2009, Junio C Hamano wrote:
>
>>   #1 "%[" introduces the nested string function.
>> 
>>   #2 After that, a name identifies what function to call.
>> 
>>   #3 The function parses its parameters ("(72,4,8)" in the above example),
>>      and makes a nested expansion on the remainder of the format string.
>
> Can't we parse it once, i.e. the first time?

I may be missing the issue you are raising here, but it parses the string only once; it stuffs the expansion of the enclosed string into a separate buffer (while noting where it ends), applies the function to the result obtained in the separate buffer and appends the result of the function application to the main buffer, and the main expansion resumes where the nested one finished.