git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] Add proof-of-concept %[w(width,in1,in2)<<any-string>>%] implementation

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 16, 2009, 08:28 UTC
Message-ID
<1255681702-5215-4-git-send-email-gitster@pobox.com>
In-Reply-To
<1255681702-5215-1-git-send-email-gitster@pobox.com>

This uses the strbuf_nested_expand() mechanism introduced earlier to demonstrate how to implement a nested string function. It does not "wrap" using the line-wrap code, but lifting the change by Dscho and plugging it in should be a trivial exercise.

The overall idea is to parse something like "%[w(72,4,8)%an %ae %s%]" in these steps:

  #1 "%[" introduces the nested string function.
  #2 After that, a name identifies what function to call.
  #3 The function parses its parameters ("(72,4,8)" in the above example),
     and makes a nested expansion on the remainder of the format string.
  #4 The nested expansion is terminated at "%]" and returned to the
     function.
  #5 The function massages the string returned from #4, and the result
     becomes the expansion of the whole thing.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 pretty.c |   84 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 84 insertions(+), 0 deletions(-)
diff --git a/pretty.c b/pretty.c
index 587101f..a8a38c3 100644
--- a/pretty.c
+++ b/pretty.c
@@ -595,6 +595,80 @@ static void format_decoration(struct strbuf *sb, const struct commit *commit)
 		strbuf_addch(sb, ')');
 }
 
+typedef int (*string_fmt_fn)(struct strbuf *sb, const char *placeholder, void *context);
+static size_t format_commit_item(struct strbuf *, const char *, void *);
+
+static int wrap_fn(struct strbuf *sb, const char *placeholder, void *context)
+{
+	const char *template = placeholder;
+	char *endptr;
+	long width = 0, indent1 = 0, indent2 = 0;
+
+	width = strtol(template, &endptr, 10);
+	if (*endptr == ',') {
+		template = endptr + 1;
+		indent1 = strtol(template, &endptr, 10);
+		if (*endptr == ',') {
+			template = endptr + 1;
+			indent2 = strtol(template, &endptr, 10);
+		}
+	}
+	if (*endptr++ != ')')
+		return 0;
+
+	template = endptr;
+	strbuf_nested_expand(sb, &template, format_commit_item, context);
+	if (*template++ != ']')
+		return 0;
+
+	/*
+	 * NEEDSWORK: here you wrap the contents of substr with
+	 * strbuf_wrap(&substr, width, indent1, indent2);
+	 *
+	 * ... but I am too lazy to do that here, and I just demonstrate
+	 * how it should work by just upcasing the result ;-)
+	 */
+	{
+		int i;
+		for (i = 0; i < sb->len; i++)
+			sb->buf[i] = toupper(sb->buf[i]);
+	}
+	return template - placeholder;
+}
+
+static struct {
+	const char *name;
+	string_fmt_fn fn;
+} format_fn_list[] = {
+	{ "w(", wrap_fn }
+};
+
+static size_t format_fn(struct strbuf *sb, const char *placeholder,
+			void *context)
+{
+	const char *template = placeholder;
+	size_t consumed;
+	struct strbuf substr = STRBUF_INIT;
+	int i;
+
+	for (i = 0; i < ARRAY_SIZE(format_fn_list); i++)
+		if (!prefixcmp(template, format_fn_list[i].name))
+			break;
+	if (ARRAY_SIZE(format_fn_list) <= i)
+		return 0;
+	template += strlen(format_fn_list[i].name);
+	consumed = format_fn_list[i].fn(&substr, template, context);
+	if (!consumed) {
+		strbuf_release(&substr);
+		return 0;
+	}
+
+	strbuf_add(sb, substr.buf, substr.len);
+	template += consumed;
+	strbuf_release(&substr);
+	return template - placeholder;
+}
+
 static size_t format_commit_item(struct strbuf *sb, const char *placeholder,
                                void *context)
 {
@@ -603,9 +677,19 @@ static size_t format_commit_item(struct strbuf *sb, const char *placeholder,
 	const char *msg = commit->buffer;
 	struct commit_list *p;
 	int h1, h2;
+	size_t nested;
 
 	/* these are independent of the commit */
 	switch (placeholder[0]) {
+	case ']':
+		return -1;
+	case '[':
+		/*
+		 * %[func(arg...) string %]: we consumed the opening '['
+		 * and the callee consumed up to the closing '%]'.
+		 */
+		nested = format_fn(sb, placeholder + 1, context);
+		return nested ? 1 + nested : 0;
 	case 'C':
 		if (placeholder[1] == '(') {
 			const char *end = strchr(placeholder + 2, ')');
-- 
1.6.5.99.g9ed7e
Previous: Junio C HamanoNext: Johannes Schindelin
Message 7 of 22 in “Generalized "string function" syntax”
  1. 0/3 Generalized "string function" syntaxJunio C Hamano, Oct 16, 2009
  2. 1/3 format_commit_message(): fix function signatureJunio C Hamano, Oct 16, 2009
  3. René ScharfeOct 17, 2009
  4. 2/3 strbuf_nested_expand(): allow expansion to interrupt in the middleJunio C Hamano, Oct 16, 2009
  5. Johannes SchindelinOct 16, 2009
  6. Junio C HamanoOct 16, 2009
  7. 3/3 Add proof-of-concept %[w(width,in1,in2)<<any-string>>%] implementationJunio C Hamano, Oct 16, 2009
  8. Johannes SchindelinOct 16, 2009
  9. Junio C HamanoOct 16, 2009
  10. Jakub NarebskiOct 16, 2009
  11. Junio C HamanoOct 16, 2009
  12. Jakub NarebskiOct 16, 2009
  13. Junio C HamanoOct 16, 2009
  14. Jakub NarebskiOct 17, 2009
  15. Junio C HamanoOct 17, 2009
  16. René ScharfeOct 17, 2009
  17. Junio C HamanoOct 18, 2009
  18. René ScharfeOct 18, 2009
  19. Junio C HamanoOct 18, 2009
  20. René ScharfeOct 19, 2009
  21. Junio C HamanoOct 19, 2009
  22. René ScharfeNov 8, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.