Re: [PATCH 3/3] Add proof-of-concept %[w(width,in1,in2)<<any-string>>%] implementation

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 16, 2009, 23:23 UTC
Message-ID: <7v7huurkif.fsf@alter.siamese.dyndns.org>
In-Reply-To: <200910170020.01756.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

> I think better solution might be to give _string_ to use for initial and
> subsequent indent rather than number of spaces... well, at least more
> generic one, allowing one to use e.g. "\t" (TAB) character to indent,
> or indent in the following way:

I do not see there is anything _better_ or _worse_. It may simply be a useful _addition_. I'd usually say "care to send in a patch?" here, but given that the general framework and the "wrap like the shortlog" hasn't been plugged-in yet, there is no need to rush.

Show 5 quoted lines

> But even with original w(<width>,<indent1>,<indent2>) we can get output
> of bare "git log" using pretty format... well, almost; it would be the
> same if there was ability to put infinite width, and there doesn't seem
> to be specifier for the whole, unchanged commit message (subject,
> unwrapped + separating lines + body).

I think I already discussed this when I sent out %s%+b patch. You would need to adjust and apply both series, but essentially it would become something like:

    %s%+[w(-1,4,4)%b]

I.e. a single subject line, potentially followed by a LF and body indented by 4-place, but the LF will be there only when the body is not empty.