git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] rev-parse: suppress duplicate log limit exceeded message.

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 23, 2010, 16:33 UTC
Message-ID
<7vr5hp1e6i.fsf@alter.siamese.dyndns.org>
In-Reply-To
<AANLkTi=3=sumzcSFoCN6FUPQPzfQvfSim8KPRoXoT3tL@mail.gmail.com>
Jon Seymour <jon.seymour@gmail.com> writes:
Show 5 quoted lines
> Ideally,  I think we should simply be reporting the log limit exceeded
> condition as a fatal condition on its own, and not reporting the
> ambiguous ref catch all at all in this case. We have already decided
> that the argument is a reference at this point and as such it is not
> really ambiguous, it just happens to be out of bounds.

A very good point. Would simply replacing that error-then-return-nonzero with a die work? If so we do not even need to worry about new mechanisms to cause different soft error conditions reported back to the caller to be printed.

Previous: Jon SeymourNext: Jon Seymour
Message 10 of 20 in “RFD: should git rev-parse exit with non-zero status if ref@{n} is not valid?”
  1. Jon SeymourAug 18, 2010
  2. Jon SeymourAug 18, 2010
  3. Junio C HamanoAug 18, 2010
  4. Jon SeymourAug 18, 2010
  5. 0/4 rev-parse: improve reporting of invalid log referencesJon Seymour, Aug 21, 2010
  6. 1/4 rev-parse: exit with non-zero status if ref@{n} is not valid.Jon Seymour, Aug 21, 2010
  7. 2/4 rev-parse: suppress duplicate log limit exceeded message.Jon Seymour, Aug 21, 2010
  8. Junio C HamanoAug 22, 2010
  9. Jon SeymourAug 23, 2010
  10. Junio C HamanoAug 23, 2010
  11. 0/2 rev-parse: strengthen validation of ref@{n} referencesJon Seymour, Aug 23, 2010
  12. 1/2 rev-parse: exit with non-zero status if ref@{n} is not valid.Jon Seymour, Aug 23, 2010
  13. Jonathan NiederAug 24, 2010
  14. 0/3 rev-parse: strengthen validation of ref@{n} referencesJon Seymour, Aug 24, 2010
  15. 1/3 rev-parse: exit with non-zero status if ref@{n} is not valid.Jon Seymour, Aug 24, 2010
  16. 2/3 sha1_name.c: use warning in preference to fprintf(stderrJon Seymour, Aug 24, 2010
  17. 3/3 rev-parse: tests git rev-parse --verify master@{n}, for various nJon Seymour, Aug 24, 2010
  18. 2/2 rev-parse: tests git rev-parse --verify master@{n}, for various nJon Seymour, Aug 23, 2010
  19. 3/4 rev-parse: introduce get_sha1_gentlyJon Seymour, Aug 21, 2010
  20. 4/4 rev-parse: tests that git rev-parse --verify master@{n}Jon Seymour, Aug 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.