git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 3/3] rev-parse: tests git rev-parse --verify master@{n}, for various n

From
Jon Seymour <jon.seymour@gmail.com>
Date
Aug 24, 2010, 04:52 UTC
Message-ID
<1282625564-12752-4-git-send-email-jon.seymour@gmail.com>
In-Reply-To
<20100824001454.GB17406@burratino>

This commit introduces tests that verify that rev-parse parses master@{n} correctly for various values of n less than, equal to and greater than the number of revisions in the reference log.

In particular, these tests check that rev-parse exits with a non-zero status code and prints a message of the following form to stderr.

    fatal: Log for [^ ]* only has [0-9][0-9]* entries.
Signed-off-by: Jon Seymour <jon.seymour@gmail.com>
---
 t/t1503-rev-parse-verify.sh    |   11 +++++++++++
 t/t1506-rev-parse-diagnosis.sh |    9 +++++++++
 2 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/t/t1503-rev-parse-verify.sh b/t/t1503-rev-parse-verify.sh
index cc65394..61092f7 100755
--- a/t/t1503-rev-parse-verify.sh
+++ b/t/t1503-rev-parse-verify.sh
@@ -104,4 +104,15 @@ test_expect_success 'use --default' '
 	test_must_fail git rev-parse --verify --default bar
 '
 
+test_expect_success 'master@{n} for various n' '
+	N=$(git reflog | wc -l) &&
+	Nm1=$((N-1)) &&
+	Np1=$((N+1)) &&
+	git rev-parse --verify master@{0} &&
+	git rev-parse --verify master@{1} &&
+	git rev-parse --verify master@{$Nm1} &&
+	test_must_fail "git rev-parse --verify master@{$N}" &&
+	test_must_fail "git rev-parse --verify master@{$Np1}"
+'
+
 test_done
diff --git a/t/t1506-rev-parse-diagnosis.sh b/t/t1506-rev-parse-diagnosis.sh
index af721f9..0eeeb0e 100755
--- a/t/t1506-rev-parse-diagnosis.sh
+++ b/t/t1506-rev-parse-diagnosis.sh
@@ -66,4 +66,13 @@ test_expect_success 'incorrect file in :path and :N:path' '
 	grep "fatal: Path '"'"'disk-only.txt'"'"' exists on disk, but not in the index." error
 '
 
+test_expect_success 'invalid @{n} reference' '
+	test_must_fail git rev-parse master@{99999} >output 2>error &&
+	test -z "$(cat output)" &&
+	grep "fatal: Log for [^ ]* only has [0-9][0-9]* entries." error  &&
+	test_must_fail git rev-parse --verify master@{99999} >output 2>error &&
+	test -z "$(cat output)" &&
+	grep "fatal: Log for [^ ]* only has [0-9][0-9]* entries." error
+'
+
 test_done
-- 
1.7.2.1.100.gceecd
Previous: Jon SeymourNext: Jon Seymour
Message 17 of 20 in “RFD: should git rev-parse exit with non-zero status if ref@{n} is not valid?”
  1. Jon SeymourAug 18, 2010
  2. Jon SeymourAug 18, 2010
  3. Junio C HamanoAug 18, 2010
  4. Jon SeymourAug 18, 2010
  5. 0/4 rev-parse: improve reporting of invalid log referencesJon Seymour, Aug 21, 2010
  6. 1/4 rev-parse: exit with non-zero status if ref@{n} is not valid.Jon Seymour, Aug 21, 2010
  7. 2/4 rev-parse: suppress duplicate log limit exceeded message.Jon Seymour, Aug 21, 2010
  8. Junio C HamanoAug 22, 2010
  9. Jon SeymourAug 23, 2010
  10. Junio C HamanoAug 23, 2010
  11. 0/2 rev-parse: strengthen validation of ref@{n} referencesJon Seymour, Aug 23, 2010
  12. 1/2 rev-parse: exit with non-zero status if ref@{n} is not valid.Jon Seymour, Aug 23, 2010
  13. Jonathan NiederAug 24, 2010
  14. 0/3 rev-parse: strengthen validation of ref@{n} referencesJon Seymour, Aug 24, 2010
  15. 1/3 rev-parse: exit with non-zero status if ref@{n} is not valid.Jon Seymour, Aug 24, 2010
  16. 2/3 sha1_name.c: use warning in preference to fprintf(stderrJon Seymour, Aug 24, 2010
  17. 3/3 rev-parse: tests git rev-parse --verify master@{n}, for various nJon Seymour, Aug 24, 2010
  18. 2/2 rev-parse: tests git rev-parse --verify master@{n}, for various nJon Seymour, Aug 23, 2010
  19. 3/4 rev-parse: introduce get_sha1_gentlyJon Seymour, Aug 21, 2010
  20. 4/4 rev-parse: tests that git rev-parse --verify master@{n}Jon Seymour, Aug 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.