From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 23 Aug 2010 16:33:57 GMT
Subject: Re: [PATCH 2/4] rev-parse: suppress duplicate log limit exceeded message.
Message-ID: <7vr5hp1e6i.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTi=3=sumzcSFoCN6FUPQPzfQvfSim8KPRoXoT3tL@mail.gmail.com>

Jon Seymour <jon.seymour@gmail.com> writes:

> Ideally,  I think we should simply be reporting the log limit exceeded
> condition as a fatal condition on its own, and not reporting the
> ambiguous ref catch all at all in this case. We have already decided
> that the argument is a reference at this point and as such it is not
> really ambiguous, it just happens to be out of bounds.

A very good point.  Would simply replacing that error-then-return-nonzero
with a die work?  If so we do not even need to worry about new mechanisms
to cause different soft error conditions reported back to the caller to be
printed.