Re: [PATCH v2 1/2] rev-parse: exit with non-zero status if ref@{n} is not valid.
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Aug 24, 2010, 00:14 UTC
- Message-ID
- <20100824001454.GB17406@burratino>
- In-Reply-To
- <1282605103-8320-2-git-send-email-jon.seymour@gmail.com>
Jon Seymour wrote:
Show 7 quoted lines
> +++ b/sha1_name.c
> @@ -342,7 +342,7 @@ static int get_sha1_1(const char *name, int len, unsigned char *sha1);
>
> static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
> {
> - static const char *warning = "warning: refname '%.*s' is ambiguous.\n";
> + static const char *warn_msg = "warning: refname '%.*s' is ambiguous.";$ git tag master $ bin-wrappers/git rev-parse master warning: refname 'master' is ambiguous.cfee1ae8f0c56eed7d8ffa821f650789f8b11de2
Here's a fixup.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> ---
diff --git a/sha1_name.c b/sha1_name.c index d40ae48..823e582 100644 --- a/sha1_name.c +++ b/sha1_name.c @@ -342,7 +342,7 @@ static int get_sha1_1(const char *name, int len, unsigned char *sha1); static int get_sha1_basic(const char *str, int len, unsigned char *sha1) { - static const char *warn_msg = "warning: refname '%.*s' is ambiguous."; + static const char *warn_msg = "warning: refname '%.*s' is ambiguous.\n"; char *real_ref = NULL; int refs_found = 0; int at, reflog_len;