Re: [PATCH] Be more careful with objects directory permissions on clone

From: Junio C Hamano <gitster@pobox.com>
Date: May 6, 2008, 06:53 UTC
Message-ID: <7vprrzhqk3.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.BSO.1.10.0805051742020.10940@zrgural.vwaro.pbz>

Mark Hills <mark@pogo.org.uk> writes:

Show 14 quoted lines

> diff --git a/git-clone.sh b/git-clone.sh
> index 8c7fc7f..9d88d1c 100755
> --- a/git-clone.sh
> +++ b/git-clone.sh
> @@ -334,7 +334,10 @@ yes)
>  			fi
>  		fi &&
>  		cd "$repo" &&
> -		find objects -depth -print | cpio $cpio_quiet_flag -pumd$l "$GIT_DIR/" || \
> +		# Create dirs using umask and permissions and destination
> +		find objects -type d -print | (cd "$GIT_DIR" && xargs mkdir -p) &&
> +		# Copy existing 0444 permissions on content
> +		find objects ! -type d -print | cpio $cpio_quiet_flag -pumd$l "$GIT_DIR/" || \
>  			exit 1

Looks much better.  Thanks.