Re: [PATCH] Be more careful with objects directory permissions on clone

From: Johannes Sixt <j.sixt@viscovery.net>
Date: May 5, 2008, 10:07 UTC
Message-ID: <481EDC4B.2010105@viscovery.net>
In-Reply-To: <alpine.BSO.1.10.0805051047260.7723@zrgural.vwaro.pbz>

Mark Hills schrieb:

Show 22 quoted lines

> On Mon, 5 May 2008, Johannes Sixt wrote:
> 
>> Mark Hills schrieb:
>>>          cd "$repo" &&
>>> -        find objects -depth -print | cpio $cpio_quiet_flag -pumd$l
>>> "$GIT_DIR/" || \
>>> +        # Create dirs using umask and permissions and destination
>>> +        find objects -type d -print | (cd "$GIT_DIR" && xargs mkdir
>>> -p) &&
>>> +        # Copy 0444 permissions on files
>>> +        find objects -type f -print | cpio $cpio_quiet_flag -pumd$l
>>> "$GIT_DIR/" || \
>>
>> Wouldn't that be better:
>>
>>     find objects ! -type d -print | cpio ...
>>
>> ?
> 
> This was my first suggestion, unfortunately it shows up broken behaviour
> in all but the latest version of cpio. It creates 0700 directory
> permissions which is even worse.

Sorry, I should have mentioned that I meant to keep the 'find | xargs mkdir' and replace only the second 'find | cpio'.

-- Hannes